Added Service as a new target type #3022
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t4lz
approved these changes
Jan 17, 2025
| @@ -87,42 +94,67 @@ fn make_simple_target_custom_schema(gen: &mut SchemaGenerator) -> schemars::sche | |||
| /// } | |||
| /// ``` | |||
| /// | |||
| /// Setup above will result in a session targeting the `bear-pod` Kubernetes pod | |||
There was a problem hiding this comment.
Suggested change
| /// Setup above will result in a session targeting the `bear-pod` Kubernetes pod | |
| /// The setup above will result in a session targeting the `bear-pod` Kubernetes pod |
| @@ -87,42 +94,67 @@ fn make_simple_target_custom_schema(gen: &mut SchemaGenerator) -> schemars::sche | |||
| /// } | |||
| /// ``` | |||
| /// | |||
| /// Setup above will result in a session targeting the `bear-pod` Kubernetes pod | |||
| /// in the user's default namespace. Target container will be chosen by mirrord. | |||
There was a problem hiding this comment.
Suggested change
| /// in the user's default namespace. Target container will be chosen by mirrord. | |
| /// in the user's default namespace. A target container will be chosen by mirrord. |
| /// } | ||
| /// ``` | ||
| /// | ||
| /// Setup above will result in a session targeting the `bear-pod-container` container |
There was a problem hiding this comment.
Suggested change
| /// Setup above will result in a session targeting the `bear-pod-container` container | |
| /// The setup above will result in a session targeting the `bear-pod-container` container |
| /// } | ||
| /// } | ||
| /// ``` | ||
| /// | ||
| /// Setup above will result in a session targeting the `bear-pod-container` container |
There was a problem hiding this comment.
Suggested change
| /// Setup above will result in a session targeting the `bear-pod-container` container | |
| /// The setup above will result in a session targeting the `bear-pod-container` container |
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub path: Option<Target>, | ||
|
|
||
| /// ### target.namespace {#target-namespace} | ||
| /// | ||
| /// Namespace where the target lives. | ||
| /// | ||
| /// Defaults to `"default"`. | ||
| /// Defaults to Kubernetes user's default namespace (defined in Kubernetes context). |
There was a problem hiding this comment.
Suggested change
| /// Defaults to Kubernetes user's default namespace (defined in Kubernetes context). | |
| /// Defaults to the Kubernetes user's default namespace (defined in Kubernetes context). |
| Pod(pod::PodTarget), | ||
|
|
||
| /// <!--${internal}--> | ||
| /// Mirror a rollout. | ||
| /// [Rollout](https://argoproj.github.io/argo-rollouts/#how-does-it-work). |
There was a problem hiding this comment.
Suggested change
| /// [Rollout](https://argoproj.github.io/argo-rollouts/#how-does-it-work). | |
| /// [Argo Rollout](https://argoproj.github.io/argo-rollouts/#how-does-it-work). |
Comment on lines
-274
to
+281
| #[allow(async_fn_in_trait)] | ||
| async fn runtime_data(&self, client: &Client, namespace: Option<&str>) -> Result<RuntimeData>; | ||
| fn runtime_data( | ||
| &self, | ||
| client: &Client, | ||
| namespace: Option<&str>, | ||
| ) -> impl Future<Output = Result<RuntimeData>>; |
| async fn get_selector_match_labels( | ||
| resource: &Self::Resource, | ||
| ) -> Result<BTreeMap<String, String>> { | ||
| fn get_selector_match_labels(resource: &Self::Resource) -> Result<BTreeMap<String, String>> { |
There was a problem hiding this comment.
Maybe we should enable clippy's unused_async lint? I'm surprised it's not on by default.
| @@ -303,13 +276,18 @@ impl ResolvedTarget<false> { | |||
| Ok(target) | |||
| } | |||
|
|
|||
| /// Check if the target can be used as a mirrord target. | |||
| /// Checks if the target can be used as a via the mirrord Operator. | |||
There was a problem hiding this comment.
This sentence needs fixing. ("... as a via ...")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.target.namespacedoc #3009