A revised attempt at ax-mulf comment wording #5032
Open
+24
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ax-mulf comment is confusing. Its text "is not a bona fide axiom for complex numbers" makes it sound like this statement can't be an axiom or that Metamath can't handle such axioms, which is obviously untrue. Also, the cited paper doesn't justify this axiom. This commit attempts to clarify the comment for ax-mulf in the hopes of making it clearer. Signed-off-by: David A. Wheeler <[email protected]>
This is in response to discussion on github and includes: - focus on the consequences of using it or not, with less language about which we prefer (because there doesn't seem to be a consensus about that). - compare with other operations - refer to mulcl rather than ax-mulcl directly - mention mpomulf
EricSchmidt-119
approved these changes
Oct 4, 2025
wlammen
approved these changes
Oct 5, 2025
icecream17
reviewed
Oct 5, 2025
Comment on lines
+84300
to
+84301
| $( Multiplication is an operation on the complex numbers. This is the | ||
| construction-dependent version of ~ ax-mulf and it should not be |
There was a problem hiding this comment.
should ax-mulf be mulcl here?
tirix
approved these changes
Oct 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have read over #4796 and attempted to incorporate the suggestions made on that issue (although the more I looked at it, the more it seemed like a slightly bigger rewording seemed to be called for).
Glad to discuss specific points but I guess for now I'll just refer to the discussion there and the commit message I have added in this pull request. I have kept @david-a-wheeler 's changes and mine in separate commits in case that makes it easier to review.