Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing gumdrop with a README #1202

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

blockiosaurus
Copy link
Contributor

No description provided.

@blockiosaurus blockiosaurus requested a review from a team as a code owner March 15, 2025 20:19
@blockiosaurus blockiosaurus requested review from nhanphan, ASCorreia, MarkSackerberg and Copilot and removed request for a team March 15, 2025 20:19
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the gumdrop program implementation with a README that redirects users to the separate mpl-gumdrop repository. Key changes include:

  • Adding a new README.md in the gumdrop directory with useful links.
  • Removing the gumdrop Rust source files, Cargo configuration, and auxiliary JavaScript SDK code and configuration files.
  • Cleaning up outdated test files and build scripts related to the old gumdrop implementation.

Reviewed Changes

Copilot reviewed 37 out of 37 changed files in this pull request and generated no comments.

Show a summary per file
File Description
gumdrop/README.md New README providing links to the new mpl-gumdrop repository
gumdrop/program/src/merkle_proof.rs Removal of the Merkle proof verification code
gumdrop/program/Xargo.toml Removal of Xargo configuration
gumdrop/program/Cargo.toml Removal of Cargo configuration for the gumdrop program
gumdrop/js/test/gumdrop.ts Removal of placeholder test file for gumdrop
gumdrop/js/src/mpl-gumdrop.ts Removal of re-exported module files
gumdrop/js/src/errors.ts Removal of error setup file
gumdrop/js/scripts/api-gen-ts.js Removal of API generation script
gumdrop/js/README.md Removal of JavaScript README previously describing gumdrop SDK
gumdrop/js/.prettierrc.js Removal of Prettier config from the JS directory
gumdrop/js/.eslintrc.js Removal of ESLint config from the JS directory
Comments suppressed due to low confidence (1)

gumdrop/README.md:1

  • [nitpick] Consider maintaining consistent naming between 'Metaplex Gumdrop' and 'MPL Gumdrop' throughout the documentation for improved clarity.
# Metaplex Gumdrop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant