Skip to content

Added dependency fontawesome package #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

raiyankamal
Copy link

When the login form is used without installing the fontawesome package, the social media icons (FB, twitter etc.) don't show up. I was able to resolve this in my environment by adding the fontawesome package. I believe this package should be included as one of the dependencies.

@splendido
Copy link
Member

I'm aware there are some default values for the icons set to FontAwesome classes...
...and I admit this is not the best.

At the same time, I'm not sure everyone would be fine by getting FontAwesome added by default.
I guess many people might have no intention to use it.

Does this makes any sense?

@raiyankamal
Copy link
Author

I understand that some people may not intend to use FA, I myself didn't. But I had to get it anyways to make the icons show up.
If FA is not included as a dependency by default, we should at least mention somewhere in the docs that the icons are borrowed from the FA package. So that users can either install FA on their own or roll their own styling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants