Skip to content

ensure JSON.parse gets a string, not an HTTParty::Response object #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

ensure JSON.parse gets a string, not an HTTParty::Response object #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1a9117
ensure JSON.parse gets a string, not an HTTParty::Response object
Jun 3, 2019
1c911a6
allow json gem >= 1.8
Mar 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bamboozled.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@ Gem::Specification.new do |spec|
spec.add_development_dependency "webmock", "~> 1.20"

spec.add_dependency "httparty", "~> 0.13"
spec.add_dependency "json", "~> 1.8"
spec.add_dependency "json", ">= 1.8"
end
5 changes: 3 additions & 2 deletions lib/bamboozled/api/base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,11 @@ def request(method, path, options = {})
case response.code
when 200..201
begin
if response.body.to_s.empty?
body = response.body.to_s
if body.empty?
{ "headers" => response.headers }
else
JSON.parse(response)
JSON.parse(body)
end
rescue
typecast = options.fetch(:typecast_values, true)
Expand Down