Skip to content

rosie ls: fix command breakage#2925

Merged
wxtim merged 1 commit into
metomi:2.5.xfrom
oliver-sanders:rosie-ls
Sep 29, 2025
Merged

rosie ls: fix command breakage#2925
wxtim merged 1 commit into
metomi:2.5.xfrom
oliver-sanders:rosie-ls

Conversation

@oliver-sanders
Copy link
Copy Markdown
Member

@oliver-sanders oliver-sanders commented Sep 16, 2025

Fix breakage caused by #2903

Turns out this code is called by other command(s).

@oliver-sanders oliver-sanders added this to the 2.5.x milestone Sep 16, 2025
@oliver-sanders oliver-sanders self-assigned this Sep 16, 2025
@oliver-sanders oliver-sanders marked this pull request as ready for review September 19, 2025 14:03
@oliver-sanders
Copy link
Copy Markdown
Member Author

To test try:

rosie checkout u-aa001
rosie checkout u-aa002
rosie ls

@oliver-sanders oliver-sanders changed the base branch from master to 2.5.x September 19, 2025 14:05
Copy link
Copy Markdown
Contributor

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed it has fixed the bug and gives the same result as Rose 2.4.2 again.

I guess we could consider adding the --no-pretty option to rosie ls but no great need.

@wxtim wxtim merged commit a3ee1c7 into metomi:2.5.x Sep 29, 2025
5 checks passed
@wxtim wxtim modified the milestones: 2.5.x, 2.5.1 Sep 29, 2025
@oliver-sanders oliver-sanders deleted the rosie-ls branch September 29, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants