Make rose check-software pick a sensible environment#3030
Open
wxtim wants to merge 3 commits intometomi:masterfrom
Open
Make rose check-software pick a sensible environment#3030wxtim wants to merge 3 commits intometomi:masterfrom
wxtim wants to merge 3 commits intometomi:masterfrom
Conversation
- Fail elegently if gi isn't intalled. - Pick up the CYLC_VERSION environment vars
wxtim
force-pushed
the
fix.rose-check-software2
branch
from
8e7f55f to
5958c17
Compare
oliver-sanders
requested changes
Mar 26, 2026
Member
oliver-sanders
left a comment
oliver-sanders
left a comment
There was a problem hiding this comment.
This fixes the case where the rose check-software command is being run behind the Cylc wapper script and Rose is installed in a Conda environment.
However, it breaks all cases where rose check-software is installed via pip or uv.
oliver-sanders
approved these changes
Mar 26, 2026
Member
oliver-sanders
left a comment
oliver-sanders
left a comment
There was a problem hiding this comment.
LGTM.
I'm guessing we want this up against a bugfix branch?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.