reassign: cover bug reassigning ping pong ping #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sttts
reviewed
Sep 2, 2020
| for _, change := range h.Changes { | ||
| switch change.FieldName { | ||
| case "cf_devel_whiteboard": | ||
| whenNotified = changedAt |
There was a problem hiding this comment.
this needs more. You have to check that AssignedModified is in the new value, but not in the old.
Are we sure history is ordered?
There was a problem hiding this comment.
@sttts we can try to sort the slice based on when beforehand to be sure.
There was a problem hiding this comment.
Or just compare whether whenNotified < changedAt. You want the last one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This controller covers the reassign "ping, pong, ping". In case the bug is moved back to original component but we already notified the assignee (AssigneeNotified), the controller we remove this label and allow "incoming" reporting to notify assignee again.