Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue 386: Incorrectly identifies channel draining as "empty code… #415

Merged
merged 3 commits into from
May 11, 2020
Merged

fix issue 386: Incorrectly identifies channel draining as "empty code… #415

merged 3 commits into from
May 11, 2020

Conversation

chavacava
Copy link
Collaborator

Closes #386

@chavacava chavacava requested a review from mgechev May 10, 2020 10:31
@chavacava chavacava mentioned this pull request May 10, 2020
Open
@mgechev
Copy link
Owner

mgechev commented May 10, 2020

We should also update the readme that this rule is now typed.

@mgechev mgechev merged commit 1da965b into mgechev:master May 11, 2020
@chavacava chavacava deleted the fix-386 branch May 25, 2020 17:43
@avorima avorima mentioned this pull request May 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgechev mgechev mgechev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrectly identifies channel draining as "empty code block"
2 participants
@chavacava @mgechev