switch to maps view 6x4 for big screens#188
Open
cryham wants to merge 2 commits intomgerhardy:masterfrom
Open
Conversation
mgerhardy
reviewed
Mar 30, 2025
| renderImage(t, x, y, colWidth, rowHeight, alpha); | ||
| } | ||
| }else{ | ||
| const int marginX = 35, padding = 20, marginXtotal = 2 * marginX + padding; |
Owner
There was a problem hiding this comment.
please don't use absolute numbers here - this means it works on your current resolution - but not on others
mgerhardy
reviewed
Mar 30, 2025
| font->printMax(title, colorWhite, fontX, fontY, colWidth); | ||
| } | ||
| } else { // big 6 x 4 | ||
| const int marginX = 25, padding = 20, marginXtotal = 2 * marginX + padding; |
Owner
There was a problem hiding this comment.
please don't use absolute numbers here.
Contributor
Author
|
Okay it's now relative to colWidth, not fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small screen stays like now but for big (on PC) this basically restores what I did in #131, that 6x4 view of maps and campaigns.
I didn't test on other resolutions.