Add priority to interfaces so that file names in interfaces.d can be prioritized#113
Open
gbeine wants to merge 1 commit intomichaelrigart:masterfrom
Open
Add priority to interfaces so that file names in interfaces.d can be prioritized#113gbeine wants to merge 1 commit intomichaelrigart:masterfrom
gbeine wants to merge 1 commit intomichaelrigart:masterfrom
Conversation
…prioritized Debian creates the interfaces following a ranking usually indicated by prepending numbers to the ifcfg-files. This will be enabled by this patch by adding a 'priority' field to interface definitions.
markgoddard
reviewed
Apr 13, 2023
| :returns: The string to prepend to an network interface filename | ||
| """ | ||
| result = "" | ||
| if interface["priority"]: |
There was a problem hiding this comment.
Do we get a KeyError if priority is not set?
Author
There was a problem hiding this comment.
Wow, this is old stuff.
I'll check the current state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debian creates the interfaces following a ranking usually indicated by prepending numbers to the ifcfg-files.
This will be enabled by this patch by adding a 'priority' field to interface definitions.
So something like
will result in the filename
20-ifcfg-lxcbr0instead ofifcfg-lxcbr0.