Enable the Utility Service in BLE Pairing Mode. #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, I've tested the CI builds and can access the log from the iOS app 🎉 |
|
This looks fine to me, I can't think how it would interfere with MicroPython, which only accesses the log through CODAL. Note: I have not tested this PR. |
dpgeorge
reviewed
Apr 3, 2024
src/codal_app/codal.json
Outdated
| @@ -10,6 +10,7 @@ | |||
| "DEVICE_STACK_SIZE": 8192, | |||
| "MICROBIT_BLE_ENABLED" : 0, | |||
| "MICROBIT_BLE_PAIRING_MODE": 1, | |||
| "MICROBIT_BLE_UTILITY_SERVICE_PAIRING": 1, | |||
There was a problem hiding this comment.
Should this go in alphabetical order, ie after MICROBIT_BLE_SECURITY_MODE?
There was a problem hiding this comment.
Yeah, I placed it there to be next to the other pairing mode config option, but make sense to move it alphabetically 👍
microbit-carlos
force-pushed
the
ble-utility-service
branch
from
fff65ca to
80df325
Compare
dpgeorge
force-pushed
the
ble-utility-service
branch
from
80df325 to
507db84
Compare
This service enables datalog access to the apps, to be able to view the logged data without a computer. This flag enables the service in pairing mode only and should have no effect when running MicroPython.
dpgeorge
force-pushed
the
ble-utility-service
branch
from
507db84 to
f1a4647
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This service enables datalog access to the apps, to be able to view the logged data without a computer.
This flag enables the service in pairing mode only and should have no effect when running MicroPython.
More info in:
MICROBIT_BLE_UTILITY_SERVICE_PAIRINGdefaults for MakeCode & MicroPython lancaster-university/codal-microbit-v2#354