mpconfigport.h: fix MICROBIT_RELEASE #229
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check master...v2.1.2 |
|
Then that's fine. But I'm not quite sure why that branch is many commits behind master. If the master branch is more updated, you may consider merging these commits into master. |
|
I see what you mean... It seems 2.1.x-branch was created at the same time as the 2.1.1 tag, the only change in 2.1.2 is a patch of the codal-nrf52 library neopixel code timings in 2.1.x-branch, and the main development has continued in master. It seems unlikely that the commits in 2.1.x-branch, including the patch, will ever need to be merged into master, because it now uses an updated version of codal-microbit-v2 which references a codal-nrf52 version that includes the same change as the patch. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.