Update translations, add French language for preview #610
Conversation
|
Preview build will be at |
| * To update all translations, pass 2 arguments: | ||
| * 1. Path to CreateAI tool translation strings directory. | ||
| * 2. Path to machine-learning-strings.json translation strings directory. | ||
| * | ||
| * To only update CreateAI tool translations, pass path to CreateAI tool | ||
| * translation strings directory as an argument. |
There was a problem hiding this comment.
I don't understand how this script ever worked.
Is it supposed to be using the local checkout of pxt-microbit-ml assuming it's up-to-date, or the latest translations from the CrowdIn .zip file?
There was a problem hiding this comment.
The latter, it's supposed to take the latest translations from the CrowdIn .zip file. I think we wanted to make sure that the default blocks would have the same and latest translations from pxt-microbit-ml when we update the extension translations
There was a problem hiding this comment.
For clarity, this script used to run based on downloading certain folders from CrowdIn with the right languages checked. Changes to this script use the translations .zip file to take away some of this manual work.
| @@ -1112,7 +1112,7 @@ | |||
| "description": "Live graph disconnected micro:bit status message" | |||
| }, | |||
| "ml.onStart|block": { | |||
| "defaultMessage": "crwdns363890:0$eventcrwdne363890:0", | |||
| "defaultMessage": "crwdns363484:0$eventcrwdne363484:0", | |||
There was a problem hiding this comment.
This feels like a mistake, we don't want to edit this reference and use the pxt-microbit-ml one
There was a problem hiding this comment.
I think we do because we want to make sure the translations used for the default blocks are the same as the pxt-microbit-ml extension ones
| @@ -1798,7 +1798,7 @@ | |||
| "ml.onStart|block": [ | |||
| { | |||
| "type": 0, | |||
| "value": "crwdns363890:0$eventcrwdne363890:0" | |||
| "value": "crwdns363484:0$eventcrwdne363484:0" | |||
Previously, I think we would do the latter and update the extension first and then update the extension version referenced (private documentation). |
We should make a preview branch that uses the the equivalent version of the extensions so we can review the whole thing in French, or update the extension in this PR.