#6313 handle out-of-order scope closure #6575
Draft
+30
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgrzej-avaloq
force-pushed
the
issues/#6313
branch
from
1a2b977 to
247e51f
Compare
Signed-off-by: Tomasz Grzejszczyk <[email protected]>
tgrzej-avaloq
force-pushed
the
issues/#6313
branch
from
247e51f to
763e0a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the issue mentions: there is more that one DB connection handled by a particular thread and the connections are not closed in the expected order causing residual scopes to be left in the
SimpleObservationRegistry(this is a memory leak plus it leads to CPU saturation with time). In the issue it is because of the specific Spring transaction handling workflow coupled with the fact that one connection is handled through theSimpleJdbcand the other one through theEntityManager. In my opinion the order of closing DB connections should be for a particular application code to decide without the observation framework imposing hard requirements.This PR does not fix the underlying problem which I think is handling disjoint scope hierarchies. It just attempts to prevent the long term corruption of the scope list in the
SimpleObservationRegistry.