[jOOQ] Fix double instrumentation in MetricsDSLContext.fetchValue(SelectField) (#6659) #6741
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
jOOQ 3.20 introduced a new DefaultDSLContext#fetchValue(SelectField) overload
that internally delegates to select(field).fetchValue(). With builder-level
instrumentation in MetricsDSLContext, that delegation leads to double
instrumentation (two jooq.query timers) and tag loss.
Solution
Override MetricsDSLContext.fetchValue(SelectField):
Verification
New JUnit 5 test
MetricsDSLContextFetchValueTestexecutesjooq.tag("name","fetchValue").fetchValue(DSL.inline(42)) against H2.
Before this change two samples were recorded; now exactly one sample is recorded.
Fixes #6659.