aiohttp: ws: fix truncated read of payload #1038
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempting to read N bytes from a socket does not guarantee to actually read N bytes, even if >= N bytes were written onto the peer socket. This especially becomes an issues when attempting to read larger messages at once, which then potentially can't be read all at once, resulting in truncated payloads. Fix that by reading as long / often until expected length was actually received.
mirko
force-pushed
the
aiohttp-ws-fix-truncated-read
branch
from
d45425d to
f245ef4
Compare
|
This should be fixed by #1034 (that was merged yesterday). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aiohttp: fix partial read on websocket resulting in truncated payload
Attempting to read N bytes from a socket does not guarantee to actually
read N bytes, even if >= N bytes were written onto the peer socket.
This especially becomes an issues when attempting to read larger
messages at once, which then potentially can't be read all at once,
resulting in truncated payloads.
Fix that by reading as long / often until expected length was actually
received.