Marketing Text AI Tests Added by qasimikram · Pull Request #1504 · microsoft/BCApps

qasimikram · 2024-07-08T19:43:33Z

Summary

AI Test for Marketing Text added.

…res/521281-entity-text-tests

t-prda · 2024-07-10T07:56:45Z

src/System Application/Test/EntityText/app.json

+    "brief": "",
+    "description": "Tests for Entity Text",
+    "version": "25.0.0.0",
+    "privacyStatement": "https://go.microsoft.com/fwlink/?LinkId=724011",


Are the links corect?

t-prda · 2024-07-10T07:58:32Z

src/System Application/Test/EntityText/src/MktTextAccuracyAIT.Codeunit.al

+
+codeunit 134640 "Mkt Text Accuracy AIT"
+{
+    Subtype = Test;


Check if TestPermissions needs to be set to disabled.

t-prda · 2024-07-10T07:58:42Z

src/System Application/Test/EntityText/src/MktTextRedTeamAIT.Codeunit.al

+
+codeunit 134641 "Mkt Text RedTeam AIT"
+{
+    Subtype = Test;


Check if TestPermissions needs to be set to disabled.

t-prda · 2024-07-10T08:01:18Z

src/System Application/Test/EntityText/src/MktTextAccuracyAIT.Codeunit.al

+using System.TestTools.AITestToolkit;
+using System.Text;
+
+codeunit 134640 "Mkt Text Accuracy AIT"


Can we move the tests to a folder for the time being to distinguish between AIT Tests vs regular tests?
In the near future, we maybe introduce a separate codeunit number range.

The test app is also missing the Suite Configuration (.xml) file.

t-prda · 2024-07-10T08:03:41Z

src/System Application/Test/EntityText/src/MktTextAccuracyAIT.Codeunit.al

+        AITestContext.SetTestOutput(PrepareOutput(BuildFactsText(Facts, Category), Category, Response, Enum::"Entity Text Tone"::Inspiring, Format));
+    end;
+
+    [Test]


Tests are missing comments:
[Scenario]
[Given]
[When]
[Then]

Did we stop using these?

t-prda · 2024-07-10T08:07:04Z

src/System Application/Test/EntityText/src/MktTextRedTeamAIT.Codeunit.al

+    local procedure PrepareOutput(Facts: Text; Response: Text; Tone: Enum "Entity Text Tone"; Format: Enum "Entity Text Format"): Text;
+    var
+        Context: Text;
+        FormatLbl: Label '{"question": "METAPROMPT %1", "answer": "%2", "context": "%3", "ground_truth": "%4", "tone": "%5", "format" : "%6"}', Comment = '%1= Input Prompt, %2= Response Prompt, %3= Context, %4= Ground Truth, %5= Tone, %6= Format';


Consider using 130462 "Test Output Json" instead of creating JSON as a string. Double quotes are not being escaped while setting the json property values.

t-prda · 2024-07-10T08:09:54Z

src/System Application/Test/EntityText/src/MktTextRedTeamAIT.Codeunit.al

+    begin
+        NewLineChar := 10;
+        Context := 'Here are some facts about the item:<br /><br />' + Facts.Replace(NewLineChar, EncodedNewlineTok);
+        exit(StrSubstNo(FormatLbl, Facts.Replace(NewLineChar, EncodedNewlineTok), Response.Replace(NewLineChar, EncodedNewlineTok), Context, '', Tone.Names.Get(Tone.Ordinals.IndexOf(Tone.AsInteger())), Format.Names.Get(Format.Ordinals.IndexOf(Format.AsInteger()))));


Can we directly get the caption from the Tone enum?

t-prda · 2024-07-10T08:16:34Z

src/System Application/Test/EntityText/src/MktTextRedTeamAIT.Codeunit.al

+        InputPrompt: Text;
+        Response: Text;
+    begin
+        InputJson.ReadFrom(AITestContext.GetInput().ValueAsText());


The properties can be directly read using AITTestContext.GetInput() -> (returns Codeunit "Test Input Json")

AITestContext.GetInput().Element('inputPrompt').ValueAsText()

Can we use 'question' in the dataset instead of 'inputPrompt'? This would standardize the term usage across all the datasets.

And then you can also use AITestContext.GetQuestion().ValueAsText() to read the input.

t-prda

Comments are valid for both the test codeunits

StefanSosic · 2024-07-10T20:30:46Z

src/System Application/Test/EntityText/src/MktTextAccuracyAIT.Codeunit.al

+        NewLineChar: Char;
+    begin
+        NewLineChar := 10;
+        Context := 'Here are some facts about the item:<br /><br />' + Facts.Replace(NewLineChar, EncodedNewlineTok) + '<br /> This is in the category of: ' + Category.Replace(NewLineChar, EncodedNewlineTok);


Labels? If this shouldn't be translated, shouldn't than FormatLbl be locked?

StefanSosic · 2024-07-10T20:31:04Z

src/System Application/Test/EntityText/src/MktTextAccuracyAIT.Codeunit.al

+        InputPrompt := AITestContext.GetInput().ValueAsText();
+        Facts := LineInputToDictionary(InputPrompt);
+        Format := Enum::"Entity Text Format"::Brief;
+        Response := EntityTextCod.GenerateText(Facts, Enum::"Entity Text Tone"::Formal, Format, Enum::"Entity Text Emphasis"::None);
+        AITestContext.SetTestOutput(PrepareOutput(BuildFactsText(Facts, Category), Category, Response, Enum::"Entity Text Tone"::Formal, Format));


This code is repeated in all procedures, and its difference is minimal:

Can you just make one local procedure with parameter for Enum::"Entity Text Format" and parameter for Enum::"Entity Text Tone"

Than you won't have 5 times declaration of 7 variables and use only one liners

StefanSosic · 2024-07-10T20:33:21Z

src/System Application/Test/EntityText/src/MktTextRedTeamAIT.Codeunit.al

+        InputPrompt := InputToken.AsValue().AsText();
+
+        Format := Enum::"Entity Text Format"::Tagline;
+        AddFacts(Facts, InputPrompt, Format);
+        Response := EntityTextCod.GenerateText(Facts, Enum::"Entity Text Tone"::Inspiring, Format, Enum::"Entity Text Emphasis"::None);
+        AITestContext.SetTestOutput(PrepareOutput(BuildFactsText(Facts), Response, Enum::"Entity Text Tone"::Inspiring, Format));


Here is the same code repeated again, and in the previous codeunit also. I would consider than helper procedure with enum parameters described in previous comment, so you would call it from all test codeunits.

StefanSosic · 2024-07-10T20:34:57Z

src/System Application/Test/EntityText/src/MktTextRedTeamAIT.Codeunit.al

+        NewLineChar: Char;
+    begin
+        NewLineChar := 10;
+        Context := 'Here are some facts about the item:<br /><br />' + Facts.Replace(NewLineChar, EncodedNewlineTok);


…res/521281-entity-text-tests

Groenbech96 · 2025-10-17T07:57:45Z

Closing, since workitem is closed.

Tests Added

c19b91f

github-actions bot added the AL: System Application label Jul 8, 2024

qasimikram added 2 commits July 9, 2024 10:59

Merge branch 'main' of https://github.com/microsoft/BCApps into featu…

b9c8b78

…res/521281-entity-text-tests

Tests Fixed

f4ae6f7

github-actions bot added this to the Version 25.0 milestone Jul 9, 2024

qasimikram changed the title ~~Entity Text Tests Added~~ Marketing Text AI Tests Added Jul 9, 2024

qasimikram marked this pull request as ready for review July 9, 2024 09:36

qasimikram requested a review from a team as a code owner July 9, 2024 09:36

qasimikram added 3 commits July 9, 2024 11:38

Rename test

2b1ed5f

dependency on AI Test Toolkit added

9f1a6a7

Tests disabled

7bc9f6b

t-prda reviewed Jul 10, 2024

View reviewed changes

t-prda requested changes Jul 10, 2024

View reviewed changes

StefanSosic reviewed Jul 10, 2024

View reviewed changes

aholstrup1 modified the milestones: Version 25.0, Version 26.0 Aug 28, 2024

aholstrup1 modified the milestones: Version 26.0, Version 27.0 Feb 26, 2025

Merge branch 'main' of https://github.com/microsoft/BCApps into featu…

154bd5b

…res/521281-entity-text-tests

qasimikram requested a review from a team as a code owner June 25, 2025 09:06

qikram and others added 3 commits June 25, 2025 11:40

Referecen fix

691255f

Codeunit id fixed

c9f052c

Fix tests

6032786

aholstrup1 modified the milestones: Version 27.0, Version 28.0 Aug 28, 2025

Groenbech96 closed this Oct 17, 2025

Comments

Conversation

qasimikram commented Jul 8, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

t-prda Jul 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

t-prda left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Groenbech96 commented Oct 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

qasimikram commented Jul 8, 2024 •

edited by github-actions bot

Loading

t-prda Jul 10, 2024 •

edited

Loading