Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[releases/25.x] [Copilot] Reduce KV checks for embed ISVs #2762

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

darjoo
Copy link
Contributor

@darjoo darjoo commented Jan 14, 2025

This pull request backports #2723 to releases/25.x

Fixes AB#562309

<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary <!-- Provide a general summary of your changes -->
ISV Embeds should be able to work with copilot and managed resources
without KV issues as they do not have the secrets needed and reduces the
effort that requires them to add specific secrets with empty values.

This does not enable them to run Microsoft 1st party copilot features on
their environments as they do not have the prompts.

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Fixes
[AB#560368](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/560368)
@darjoo darjoo requested a review from a team as a code owner January 14, 2025 09:10
@github-actions github-actions bot added this to the Version 25.4 milestone Jan 14, 2025
@darjoo darjoo merged commit 6abb776 into releases/25.x Jan 15, 2025
26 of 27 checks passed
@darjoo darjoo deleted the backport/releases/25.x/2723/20250114100952 branch January 15, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants