[28.3] Fix VariantCode lost during Contract Price Update proposal - #9854
Open
djukicmilica wants to merge 1 commit into
Open
[28.3] Fix VariantCode lost during Contract Price Update proposal#9854djukicmilica wants to merge 1 commit into
djukicmilica wants to merge 1 commit into
Conversation
Pass ServiceObject."Variant Code" through CreateTempSalesLine and CreateTempPurchaseLine overloads so the pricing engine picks up variant-specific prices instead of defaulting to the base item price. Also add the missing TempPurchaseLine."Variant Code" := VariantCode assignment in the full purchase line overload. Fixes Bug 644745
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #9850 into releases/28.3
Why
When using the Recent Item Prices method in Subscription Contract Price Update, the system proposes the base item price instead of the variant-specific price. The
VariantCodefrom the Subscription Header is never passed to the temporary Sales/Purchase Line used for price calculation.Summary
CreateTempSalesLineServiceObject overload to passServiceObject."Variant Code"to the full overloadCreateTempPurchaseLineServiceObject overload — same fixTempPurchaseLine."Variant Code" := VariantCodeassignmentAB#644745