Skip to content

[28.3] Fix VariantCode lost during Contract Price Update proposal - #9854

Open
djukicmilica wants to merge 1 commit into
microsoft:releases/28.3from
djukicmilica:hotfix/644745-variant-code-28.3
Open

[28.3] Fix VariantCode lost during Contract Price Update proposal#9854
djukicmilica wants to merge 1 commit into
microsoft:releases/28.3from
djukicmilica:hotfix/644745-variant-code-28.3

Conversation

@djukicmilica

@djukicmilica djukicmilica commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Cherry-pick of #9850 into releases/28.3

Why

When using the Recent Item Prices method in Subscription Contract Price Update, the system proposes the base item price instead of the variant-specific price. The VariantCode from the Subscription Header is never passed to the temporary Sales/Purchase Line used for price calculation.

Summary

  • Fixed CreateTempSalesLine ServiceObject overload to pass ServiceObject."Variant Code" to the full overload
  • Fixed CreateTempPurchaseLine ServiceObject overload — same fix
  • Removed dead-code 6-param local overloads that hardcoded empty VariantCode
  • Added missing TempPurchaseLine."Variant Code" := VariantCode assignment

AB#644745

Pass ServiceObject."Variant Code" through CreateTempSalesLine and
CreateTempPurchaseLine overloads so the pricing engine picks up
variant-specific prices instead of defaulting to the base item price.

Also add the missing TempPurchaseLine."Variant Code" := VariantCode
assignment in the full purchase line overload.

Fixes Bug 644745
@djukicmilica
djukicmilica requested a review from a team July 30, 2026 11:51
@djukicmilica
djukicmilica requested a review from a team as a code owner July 30, 2026 11:51
@github-actions github-actions Bot added AL: Apps (W1) Add-on apps for W1 From Fork Pull request is coming from a fork Finance GitHub request for Finance area Linked Issue is linked to a Azure Boards work item labels Jul 30, 2026
@github-actions github-actions Bot added this to the Version 28.3 milestone Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 Finance GitHub request for Finance area From Fork Pull request is coming from a fork Linked Issue is linked to a Azure Boards work item

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant