Skip to content

Include item identifiers in Sales Order Agent searches - #9856

Merged
qasimikram merged 1 commit into
mainfrom
qasimikram/soa-item-identifier-search
Jul 30, 2026
Merged

Include item identifiers in Sales Order Agent searches#9856
qasimikram merged 1 commit into
mainfrom
qasimikram/soa-item-identifier-search

Conversation

@qasimikram

@qasimikram qasimikram commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Include item numbers, SKUs, product codes, vendor item numbers, and catalog numbers in item search text when provided
  • Preserve item identifiers exactly, including punctuation
  • Continue normalizing spelling and singular forms only for descriptive keywords
  • Prevent description-only searches when the request contains an item identifier

AB#641231

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@qasimikram
qasimikram requested a review from a team July 30, 2026 12:04
@github-actions github-actions Bot added AL: Apps (W1) Add-on apps for W1 SCM GitHub request for SCM area labels Jul 30, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Jul 30, 2026
@qasimikram
qasimikram enabled auto-merge July 30, 2026 12:21

@PredragMaricic PredragMaricic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions:

S1 - Require the identifier to be the first search term. SOAItemSearch.GetItemFilters treats only the first search keyword as a potential exact Item."No." lookup. Update the prompt to require the identifier first so descriptive terms cannot bypass the deterministic exact-match path.

S2 - Add regression evaluation evidence for an order line containing an identifier plus a noisy or mismatched description. Verify that search preserves the identifier, places it first, and selects the exact item; compile and unit-build checks do not establish prompt behavior.

S3 - Clarify requirement traceability. AB#641231 covers replacing Document Intelligence with direct model document reading, but its acceptance metrics do not specify identifier-search behavior. Link the specific requirement or document the relevant acceptance criterion and validation in this PR.

@qasimikram
qasimikram added this pull request to the merge queue Jul 30, 2026
Merged via the queue into main with commit 1e77e9c Jul 30, 2026
328 of 333 checks passed
@qasimikram
qasimikram deleted the qasimikram/soa-item-identifier-search branch July 30, 2026 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 SCM GitHub request for SCM area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants