Always prefer peer's snapshot #7314
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjen1-msft
reviewed
Sep 29, 2025
achamayou
approved these changes
Sep 29, 2025
achamayou
added
auto-backport
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
achamayou
reviewed
Sep 30, 2025
cjen1-msft
reviewed
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we'd compare versions of snapshots we read from disk, and only take one from the peer if it was more recent. But this still exposes us to file system sync issues with snapshots.
This changes to always take a snapshot from the peer, if one is available.
Since that might mean we already have an identically-named snapshot, we also now overwrite any existing snapshot (with a corresponding log line).