Closing guards around tcp handles #7326
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing an ASAN failure.
The specific issue is that the node can accept a connection (and a couple of other uv callbacks) while the handle is being closed.
The error below is caused by the on_accept incrementing the connection id when the ConnIdGenerator has already gone out of scope.
There are a couple of other spots in the tcp.h file where we should probably have similar checks, but these are two that I am sure are correct to do.
(on_write, on_resolved, on_alloc and on_read, seem like good candidates, on_reconnect seems suspicious generally)