-
Notifications
You must be signed in to change notification settings - Fork 132
Close SDL coverage gaps and fix rules that could never match #780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Giulia Stocco (gfs)
wants to merge
35
commits into
main
Choose a base branch
from
gfs-sdl-ruleset-gap-audit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 24 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
f53acad
Ship the Android and XSLT rules that were never embedded
gfs 47cead3
Give the two distinct DS440011 rules separate IDs
gfs 5ac108e
Close the banned API gap against SDL ADM.10082
gfs 594e50a
Cover the deserializers ADM.10010 names as unsafe
gfs ea57b29
Extend XXE coverage beyond Objective-C and Swift
gfs 9173bf1
Use the JSONPath, YAMLPath and XPath support the engine already has
gfs 2fd4a6a
Add missing language definitions and target React files
gfs e3d9f12
Detect private keys and provider tokens, and fix a JSONC regression
gfs c0e3107
Give every rule a self-test, which surfaced three dead rules
gfs 258bb29
Add changelog entry for the SDL coverage work
gfs 9d0be0c
Make DevSkim's overrides survive the containment change in AppInspect…
gfs 5efcc07
Record the override compatibility fixes in the changelog
gfs 8878c63
Move to ApplicationInspector 1.10.1
gfs 218425b
Record the 1.10.1 move in the changelog
gfs d5d548f
Use obviously fake sample values in the token self-tests
gfs 387cc2d
Add boolean expression rules and update security rules in Application…
gfs 4745b8b
Merge main and preserve released changelog history
gfs a397ecc
Fix React comment handling and pip requirements coverage
gfs ccb5882
Correct Kubernetes, SQL Server, and NuGet rule matching
gfs 3b21c1d
Fix multiline Python XML and YAML safety checks
gfs b2f49a2
Scope HTML link protections to each anchor tag
gfs bdde0f9
Respect HTTP header boundaries and quoted cookie values
gfs 3a7b50d
Validate HSTS directive structure and reject duplicates
gfs f473e68
Fix React and Razor language routing
gfs 672ab51
Fix untagged private registry image detection
gfs 320426c
Match connection string options case-insensitively
gfs a5dc6bc
Fix package source rule coverage
gfs e05306e
Scope HTML link suppression to each anchor
gfs 6ec09a1
Fix XXE rules for FSharp and lxml
gfs d5a9500
Document review fixes
gfs 3dec9d1
Merge remote-tracking branch 'origin/main' into gfs-sdl-ruleset-gap-a…
gfs 1b0fce8
Merge remote review fixes and resolve rule conflicts
gfs 5b43070
Fix nested PyYAML loads and raw header apostrophe handling
gfs d2eb001
Allow apostrophes in unquoted headers and document Razor rule scoping
gfs 61c6f83
Address review: comment mappings, TLS false positives, VB casing, gui…
gfs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.