Skip to content

Conversation

zhiyuanliang-ms
Copy link
Contributor

Why this PR?

Add more testcases & remove unused code

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/feature-management/test/featureManager.test.ts:215

  • The 'requirement_type' for 'AnyFeature' is commented out, which might lead to unexpected behavior. Uncomment or explicitly set the 'requirement_type' to ensure the test case is valid.
// "requirement_type": "Any",

src/feature-management/test/variant.test.ts:88

  • The error message should specify that the 'from' and 'to' values must be numbers between 0 and 100.
await expect(featureManager.getVariant(Features.VariantFeatureInvalidFromTo, context))

@zhiyuanliang-ms zhiyuanliang-ms merged commit 00794c6 into main Feb 12, 2025
5 checks passed
@zhiyuanliang-ms zhiyuanliang-ms deleted the zhiyuanliang/update-test-case branch February 12, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants