refactor(presence): Create branded JsonDeserialized type #24641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: framework
tylerbutler
changed the title
jason-ha
reviewed
May 15, 2025
jason-ha
reviewed
May 15, 2025
| * @system | ||
| */ | ||
| export declare class JsonDeserializedBrand<T> { | ||
| private readonly JsonDeserialized: JsonDeserialized<T>; |
There was a problem hiding this comment.
We can probably drop the JsonDeserialized<T>. Just T is probably enough. Probably want to use the dummy accessor and iterator found in that reference PR's brand classes.
jason-ha
reviewed
May 15, 2025
Comment on lines
274
to
275
| const unbrandedValue = fromJsonDeserializedHandle(item.value); | ||
| callbackfn(asDeeplyReadonly(unbrandedValue), key, this); |
There was a problem hiding this comment.
Can probably combine both of these pass-through helper functions.
jason-ha
reviewed
May 15, 2025
Comment on lines
280
to
281
| const data = this.value.items[key]?.value; | ||
| return data === undefined ? undefined : asDeeplyReadonly(fromJsonDeserializedHandle(data)); |
There was a problem hiding this comment.
Kind of silly since those are both pass through anyway - should be able to adjust the helper to handle it.
|
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the presence internals to use a branded internal type when passing around JsonDeserialized objects. There are two functions to brand and unbrand a JsonDeserialized object.
Externally, the API remains the same; the internal types and functions are marked
@systemand objects are converted between the types at the API boundaries.