feat(aqueduct): Expose ITree & ISharedObject type for TreeDataObject's SharedTree #24684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-msft/FluidFramework into treeDataObject/change-tree
jikim-msft
requested review from
Copilot and
Josmithr
and removed request for
Copilot
github-actions
bot
added
area: framework
Josmithr
approved these changes
May 22, 2025
|
|
||
| /** | ||
| * Gets the underlying {@link @fluidframework/tree#ITree | tree}. | ||
| */ | ||
| public get sharedTree(): ITree { | ||
| public get sharedTree(): ITree & ISharedObject { |
There was a problem hiding this comment.
this seems incorrect. the docs on the type say:
There was a problem hiding this comment.
seems fine internally, but i don't think the public getter should expose it
There was a problem hiding this comment.
Hey @anthony-murphy, after going through the doc more thoroughly, I agree with your point. Will close this PR. Thanks!
There was a problem hiding this comment.
i think the change was fine besides the public exposure on the getter. using it internally made the bind cast better which i thought was fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR exposes
ITree & ISharedObjecttype for theTreeDataObject.sharedTreeproperty.Relevant PR & Discussion
#24523 (comment)