Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HandledErrorLog.java to improve naming #566

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Update HandledErrorLog.java to improve naming #566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a392627
Update HandledErrorLog.java to increase naming
hydraxman Aug 4, 2023
0e229bf
apply the rename and get build pass
hydraxman Sep 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/src/main/java/com/microsoft/hydralab/common/appcenter/AppCenterErrorLogHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ public HandledErrorLog createErrorLog(final Thread thread, final Throwable throw
/* Uncaught exception or managed exception. */
errorLog.setFatal(fatal);
if (!fatal) {
errorLog.setType(HandledErrorLog.TYPE);
errorLog.setType(HandledErrorLog.WARNING_TYPE);
}

/* Application launch time. */
Expand Down
6 changes: 5 additions & 1 deletion common/src/main/java/com/microsoft/hydralab/common/appcenter/entity/HandledErrorLog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public class HandledErrorLog implements Log {
/**
* Log type.
*/
public static final String TYPE = "handledError";
public static final String WARNING_TYPE = "handledError";

/**
* Exception associated to the error.
Expand Down Expand Up @@ -47,6 +47,10 @@ public class HandledErrorLog implements Log {
* The optional user identifier.
*/
private String userId;
/**
* "managedError" -> AppCenter Crash
* "handledError" -> AppCenter Error
*/
private String type = "managedError";

/**
Expand Down