-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed misc CRAN issues #1260
Fixed misc CRAN issues #1260
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
^build_package.R$ |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,13 +5,16 @@ Version: 2.1.0 | |
Date: 2018-01-25 | ||
Author: Guolin Ke <[email protected]> | ||
Maintainer: Guolin Ke <[email protected]> | ||
Description: LightGBM is a gradient boosting framework that uses tree based learning algorithms. | ||
Description: Tree based algorithms can be improved by introducing boosting frameworks. LightGBM is one such framework, and this package offers an R interface to work with it. | ||
It is designed to be distributed and efficient with the following advantages: | ||
1. Faster training speed and higher efficiency. | ||
2. Lower memory usage. | ||
3. Better accuracy. | ||
4. Parallel learning supported. | ||
5. Capable of handling large-scale data. | ||
In recognition of these advantages, LightGBM has being widely-used in many winning solutions of machine learning competitions. | ||
|
||
Comparison experiments on public datasets suggest that LightGBM can outperform existing boosting frameworks on both efficiency and accuracy, with significantly lower memory consumption. In addition, parallel experiments suggest that in certain circumstances, LightGBM can achieve a linear speed-up in training time by using multiple machines. | ||
License: MIT + file LICENSE | ||
URL: https://github.com/Microsoft/LightGBM | ||
BugReports: https://github.com/Microsoft/LightGBM/issues | ||
|
@@ -30,6 +33,7 @@ Depends: | |
R (>= 3.0), | ||
R6 (>= 2.0) | ||
Imports: | ||
graphics, | ||
methods, | ||
Matrix (>= 1.1-0), | ||
data.table (>= 1.9.6), | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,10 +16,8 @@ CVBooster <- R6Class( | |
) | ||
) | ||
|
||
#' Main CV logic for LightGBM | ||
#' | ||
#' Main CV logic for LightGBM | ||
#' | ||
#' @title Main CV logic for LightGBM | ||
#' @name lgb.cv | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this and |
||
#' @param params List of parameters | ||
#' @param data a \code{lgb.Dataset} object, used for CV | ||
#' @param nrounds number of CV rounds | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -122,5 +122,28 @@ NULL | |
# Various imports | ||
#' @import methods | ||
#' @importFrom R6 R6Class | ||
#' @useDynLib lightgbm | ||
#' @useDynLib lib_lightgbm | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was unable to build the package without making this change |
||
NULL | ||
|
||
# Suppress false positive warnings from R CMD CHECK about | ||
# "unrecognized global variable" | ||
globalVariables(c( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This suppresses the |
||
"." | ||
, ".N" | ||
, ".SD" | ||
, "Contribution" | ||
, "Cover" | ||
, "Feature" | ||
, "Frequency" | ||
, "Gain" | ||
, "internal_count" | ||
, "internal_value" | ||
, "leaf_index" | ||
, "leaf_parent" | ||
, "leaf_value" | ||
, "node_parent" | ||
, "split_feature" | ||
, "split_gain" | ||
, "split_index" | ||
, "tree_index" | ||
)) |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guolinke per your request, I've included additional details here. You will recognize most of this from the README you linked me too. I also added the line about "this is the R interface to the project" following the way XGBoost structured their DESCRIPTION: https://cran.r-project.org/web/packages/xgboost/index.html
I think that's a good clarification for people, to say that
LightGBM
is a framework and this is the interface to it implemented in a particular programming language.