[python-package] Add tests for passing Arrow arrays with empty chunks #6210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borchero
requested review from
guolinke,
jameslamb,
shiyu1994 and
jmoralez
as code owners
This was referenced Dec 4, 2023
jameslamb
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Hey great, thanks for looking into this!
I agree with skipping them. I can't think of a reason LightGBM should need to care about preserving the empty chunks on its side... it just wants to get from raw input data (chunked array) to the format for training (LightGBM Dataset) correctly and efficiently.
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Follow-up from #6166. Thanks a lot for proposing this test @jameslamb, it actually caught an error in the C++ code! I'm now ignoring empty chunks as keeping them around would make life hard (
.begin()couldn't beO(1)anymore which violates assumptions about iterators).Turns out we just got lucky in #6166 as the chunked array being initialized is contiguous in memory...