-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python-package] support Python 3.13 #6668
Conversation
We'll need to wait for the rest of LightGBM's dependencies to get Python 3.13 packages on
But hey, at least We can check the state of LightGBM's dependencies here: https://conda-forge.org/status/migration/?name=python313 |
|
The conda-forge Python 3.13 migration is making progress, but looks like not all of PR to subscribe to: conda-forge/cffi-feedstock#53 |
good news: conda-forge migrations we needed for Python 3.13 appear to be done! (successful macOS Python 3.13 build) bad news: seems like conda isn't able to find a solution for our CI environment on x86_64 Python 3.9 (failed macOS x86_64 Python 3.9 build, failed Linux x86_64 Python 3.9 job Not sure about the root cause yet, will try to investigate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
I checked that there are no any other places to bump Python version.
I left some comments for your consideration below.
@@ -66,7 +66,7 @@ if ($env:TASK -eq "swig") { | |||
conda init powershell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not to bump version in Appveyor?
Line 6 in 3654eca
- '3.8' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking that because we use Appveyor to test such an old version of VS Code:
Line 3 in 3654eca
image: Visual Studio 2015 |
That it should stay frozen on an old Python version too, until supporting that older Python version on Appveyor breaks. Given that, do you think we should make increasing this version to 3.9
part of this update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, makes sense! I don't mind leaving 3.8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making Python 3.13 work here!
I'm approving because the diff looks good to me and CI is green. I didn't check all CI logs to ensure that correct Python version is used there.
Please update Ubuntu version in docs:
Line 38 in 3aac25a
readthedocs/build:ubuntu-20.04-2021.09.23 \ |
Just pushed 6af26b1 doing that. I tested this locally and it worked well for me. Thanks as always for your thoroughness! |
Add support for Python 3.13, now that it's available: https://docs.python.org/3/whatsnew/3.13.html
This also proposes a new standard process for Python version upgrades in this project. Proposing that when a new Python version is generally available, we do the following:
3.10 -> 3.11
)test-old-versions
CI job (as I've done here with Python 3.8)This makes the updates easy to make and review, and reduces the risk of issues like #5969 and #6680 leading to maintenance work.