Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] fix build of LightGBM with MSVS GUI #6690

Merged
merged 1 commit into from
Oct 21, 2024
Merged

[ci] fix build of LightGBM with MSVS GUI #6690

merged 1 commit into from
Oct 21, 2024

Conversation

StrikerRUS
Copy link
Collaborator

No description provided.

jameslamb
jameslamb approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't develop on Windows often and when I do I don't use the MSVS GUI, so I didn't test this, but changes make sense to me. Thanks!

@StrikerRUS StrikerRUS merged commit 99e27b8 into master Oct 21, 2024
48 checks passed
@StrikerRUS StrikerRUS deleted the msvs/fix-debug branch October 21, 2024 15:34
@StrikerRUS StrikerRUS mentioned this pull request Oct 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@guolinke guolinke Awaiting requested review from guolinke guolinke is a code owner

@shiyu1994 shiyu1994 Awaiting requested review from shiyu1994 shiyu1994 is a code owner

@jmoralez jmoralez Awaiting requested review from jmoralez jmoralez is a code owner

@borchero borchero Awaiting requested review from borchero borchero is a code owner

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StrikerRUS @jameslamb