[ci] [R-package] re-enable 'rchk' checks #6713
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #6545
Proposes re-enabling the
rchk
checks, now that that tool can successfully checklightgbm
's source code: kalibera/rchk#35 (comment)How I tested this
Intentionally caused a stack imbalance by reducing the count in an
Rf_UNPROTECT()
call by 1: https://github.com/microsoft/LightGBM/pull/6713/files#diff-effa19f4965843414974b8ad1ddcf65710b25c978e203317ce409749841da338Saw
rchk
catch it!(build link)
Then reverted that, and saw
rchk
exit normally and not report any issues:(build link)