Skip to content

chore: flatten namespace hierarchy #2368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 27, 2025
Merged

Conversation

MaggieKimani1
Copy link
Contributor

Flattens namespaces to align with single top-level namespace
Fiixes #2367

@MaggieKimani1 MaggieKimani1 requested a review from a team as a code owner May 26, 2025 13:26
@MaggieKimani1 MaggieKimani1 self-assigned this May 26, 2025
@darrelmiller
Copy link
Member

darrelmiller commented May 27, 2025

Sorry, I missed a few namespaces in the list I created in the issue. We should also remove

Microsoft.OpenApi.Extensions
Microsoft.OpenApi.Services
Microsoft.OpenApi.Validations
Microsoft.OpenApi.Writers

The Extensions one is especially important because the discovery of extension methods is hard when they are in a different namespace.

@MaggieKimani1
Copy link
Contributor Author

Sorry, I missed a few namespaces in the list I created in the issue. We should also remove

Microsoft.OpenApi.Extensions Microsoft.OpenApi.Services Microsoft.OpenApi.Validations Microsoft.OpenApi.Writers

The Extensions one is especially important because the discovery of extension methods is hard when they are in a different namespace.

What about Microsoft.OpenApi.Expressions?

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
66.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@MaggieKimani1 MaggieKimani1 enabled auto-merge May 27, 2025 19:22
@MaggieKimani1 MaggieKimani1 merged commit 2f9a78b into main May 27, 2025
16 of 17 checks passed
@MaggieKimani1 MaggieKimani1 deleted the fix/flatten-namespaces branch May 27, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants