-
Notifications
You must be signed in to change notification settings - Fork 258
Remove KeyComparer property from OpenApiWriterSettings #2375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: baywet <[email protected]>
…terSettings Co-authored-by: baywet <[email protected]>
Co-authored-by: baywet <[email protected]>
…nsions files Co-authored-by: baywet <[email protected]>
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@baywet, shouldn't the PR title be renamed to match conventional commit. i.e. |
@baywet, this is based on the naming convention used for closed PRs in this repo - https://github.com/microsoft/OpenAPI.NET/pulls?q=is%3Apr+is%3Aclosed. However, based on the releases, it appears that release notes are generated from commit messages rather than PR titles. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yes release notes are using the commits messages. |
Thanks! |
Following discussions in #2363, this PR removes the
KeyComparer
property fromOpenApiWriterSettings
class as ordered collections are sufficient for the library's needs.Changes Made
KeyComparer
property fromOpenApiWriterSettings.cs
OpenApiWriterExtensions.cs
to remove custom sorting:WriteCollectionInternal
methodWriteMapInternal
methodCollectionExtensionsTests.cs
:SortOpenApiDocumentUsingCustomComparerSucceeds
testSortHashSetsWorks
testSortTagsByNameUsingComparerWorks
test and associatedOpenApiTagNameComparer
classCollectionExtensions.cs
:Sort<TKey, TValue>
method for dictionariesSort<T>
method for enumerablesPublicApi.approved.txt
to reflect removed propertyImpact
The removal of custom comparer functionality aligns with the decision to rely on ordered collections instead. Collections and maps will now be written in their natural order rather than using custom sorting logic.
Testing
Fixes #2374.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
http://168.63.129.16:80/machine/
/usr/bin/python3 -u bin/WALinuxAgent-2.13.1.1-py3.9.egg -collect-logs
(http block)http://www.microsoft.com:80/pkiops/crl/Microsoft%20Identity%20Verification%20Root%20Certificate%20Authority%202020.crl
dotnet build
(http block)http://www.microsoft.com:80/pkiops/crl/Microsoft%20Public%20RSA%20Timestamping%20CA%202020.crl
dotnet build
(http block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.