Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving dependency scan to CORE #2827

Merged
merged 8 commits into from
Feb 7, 2025
Merged

Moving dependency scan to CORE #2827

merged 8 commits into from
Feb 7, 2025

Conversation

anderson-joyle
Copy link
Contributor

Issue #2809.

@anderson-joyle anderson-joyle requested a review from a team as a code owner January 22, 2025 22:03
@LucGenetier
Copy link
Contributor

LucGenetier commented Jan 23, 2025 •
edited by anderson-joyle
Loading

✅ No public API change. #Resolved

@LucGenetier
Copy link
Contributor

LucGenetier commented Jan 24, 2025 •
edited by anderson-joyle
Loading

✅ No public API change. #Resolved

@MikeStall
Copy link
Contributor

MikeStall commented Feb 3, 2025 •
edited by anderson-joyle
Loading 

            var list = _engine.IRTransformList;

EnableDelegation adds here #Resolved

Refers to: src/libraries/Microsoft.PowerFx.Core/Public/CheckResult.cs:557 in 9cf7085. [](commit_id = 9cf7085, deletion_comment = False)

@MikeStall
Copy link
Contributor

MikeStall commented Feb 3, 2025 •
edited by anderson-joyle
Loading 

            (var irnode, var ruleScopeSymbol) = IRTranslator.Translate(binding);

save this as "IRNode before transforms"
#Resolved

Refers to: src/libraries/Microsoft.PowerFx.Core/Public/CheckResult.cs:555 in 9cf7085. [](commit_id = 9cf7085, deletion_comment = False)

@anderson-joyle anderson-joyle force-pushed the andersonf/dependency-scan branch from a224745 to 4a6b07c Compare February 6, 2025 23:09
@LucGenetier
Copy link
Contributor

LucGenetier commented Feb 7, 2025 •
edited by anderson-joyle
Loading

✅ No public API change. #Resolved

@LucGenetier
Copy link
Contributor

✅ No public API change.

MikeStall
MikeStall approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@MikeStall MikeStall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anderson-joyle anderson-joyle merged commit d0e2f0d into main Feb 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jas-valgotar jas-valgotar jas-valgotar left review comments

@MikeStall MikeStall MikeStall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anderson-joyle @LucGenetier @MikeStall @jas-valgotar