-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FancyZones Editor] Quick layout switch hotkeys #10437
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck keys, telemetry (#10243)
* Started work * Do not swallow the key press, for now * Use Alt+Shift, check whether to swallow the key * The feature works, now we need to integrate settings * Use settings to disable switching * Flashing has some bugs * Fix concurrency bugs * Remove unused function * Add tracing to Flash() * There are still concurrency bugs * Removed unused code. There are more MT bugs still, don't review yet * Require locks in various places * Satisfy the spell checker * Add support for numpad keys, changing layout while dragging * Add helper functions * Move flash check * Implement and use GetWorkAreaFromCursor * Enable single key switch while dragging a window
#10409) * Update device info when setting custom zone sets * Add telemetry call
* Update resource string * Update key order
enricogior
approved these changes
Mar 25, 2021
enricogior
pushed a commit
that referenced
this pull request
Mar 26, 2021
Co-authored-by: Ivan Stošić <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
FancyZones-Editor
Issue revolving the FancyZone Editor
FancyZones-Hotkeys
Issue around shortcut keys in FancyZones
Product-FancyZones
Refers to the FancyZones PowerToy
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about:
Layouts can be quickly changed by the hotkey
Win + Ctrl + Alt + number
. Another way to quickly switch layout is during the window dragging press a number assigned to the layout.The feature could be enabled/disabled in the FancyZones settings along with the flashing zones option.
The number is defined by the user in the FancyZones Editor.
Hotkeys could be assigned to custom layouts.
What is include in the PR:
How does someone test / validate:
Quality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.