Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWB] Migrate to PowerToys-style shortcuts and disable Ctrlx3 for mul… #27442

Merged
merged 14 commits into from
Jul 26, 2023

Conversation

yuyoyuppe
Copy link
Contributor

…tiple mode

Summary of the Pull Request

Standardize shortcut handling for MWB to follow the same practice we use for other modules.

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

  • change hotkeys on v0.70
  • load them for this branch
  • use them, change them again

@yuyoyuppe yuyoyuppe requested a review from jaimecbernardo July 14, 2023 11:43
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided on not having the custom screen capture feature anymore, since Windows now has a snipping tool which can be used for that effect. Can you please remove it?
How can we disable a shortcut with the current UI?

@jaimecbernardo
Copy link
Collaborator

I think we should also set new defaults to shortcuts that won't conflict with Ctrl+Alt+Letter.
I guess Ctrl+Alt+Win+Letter would be good but first please check if that won't conflict with other shortcuts for the letters we currently have associated.

@yuyoyuppe yuyoyuppe requested a review from jaimecbernardo July 20, 2023 09:09
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving it a test, Press Ctrl three times is upgrading into VK1? It should be disabled, I think.
image

@yuyoyuppe yuyoyuppe requested a review from jaimecbernardo July 24, 2023 15:28
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried the new default Windows+Control+Alt+L to lock all machines and it seems to not be working. Works when I set it to a different combination, though.
Can you please check if the new defaults work out of the box?
When I press Windows+Ctrl+Alt+L it sends the pointer to the center of the screen, which is weird?
image

@yuyoyuppe yuyoyuppe requested a review from jaimecbernardo July 25, 2023 17:22
@yuyoyuppe
Copy link
Contributor Author

@jaimecbernardo updated, PTAL

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the enhancement and fixes!

@jaimecbernardo jaimecbernardo merged commit a99b2e0 into microsoft:main Jul 26, 2023
@yuyoyuppe yuyoyuppe deleted the mwb_shortcuts branch July 26, 2023 12:06
@davidegiacometti davidegiacometti mentioned this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants