Different units for trigonometric functions in PowerToys Run calculator plugin #36717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
This comment has been minimized.
This comment has been minimized.
htcfreek
suggested changes
Jan 6, 2025
...modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.Calculator/Properties/Resources.resx
Outdated
Show resolved
Hide resolved
Co-authored-by: Heiko <[email protected]>
This comment has been minimized.
This comment has been minimized.
htcfreek
approved these changes
Jan 12, 2025
htcfreek
added
the
Needs-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Added option to select angle unit for trigonometric calculations in the PowerToys Run calculator plugin.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Added option in settings to allow the user to select between "Radians", "Degrees", or "Gradians".
Extra expression parsing used to add mathematical conversions for the units, as Mages does not natively support units other than radians.
Added suitable tests of the extra expression parsing, all pass.
Validation Steps Performed
Suitable tests added for extra expression parsing, all pass.
Tested feature mathematically.