Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic Literal Validator #7009

Merged
merged 3 commits into from
Mar 26, 2025

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Mar 26, 2025

Add a validator that allows you to validate against typing.Literal

  • Changelog entry

@jenshnielsen jenshnielsen requested a review from a team as a code owner March 26, 2025 10:16
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 56.25000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 59.92%. Comparing base (6c5f508) to head (7b04e57).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/qcodes/validators/validators.py 56.25% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7009   +/-   ##
=======================================
  Coverage   59.92%   59.92%           
=======================================
  Files         342      342           
  Lines       31411    31426   +15     
=======================================
+ Hits        18823    18832    +9     
- Misses      12588    12594    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newsfragment ? :)

@jenshnielsen
Copy link
Collaborator Author

newsfragment ? :)

Yes see todo in description :)

@jenshnielsen jenshnielsen added this pull request to the merge queue Mar 26, 2025
Merged via the queue into microsoft:main with commit 8c017ea Mar 26, 2025
17 of 18 checks passed
@jenshnielsen jenshnielsen deleted the literal_validator branch March 26, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants