Optimized divisionless implementation of minstd #5256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have traced the optimization to the following paper:
Carta, David F. "Two fast implementations of the “minimal standard” random number generator." Communications of the ACM 33, no. 1 (1990): 87-88.
BEFORE:
Benchmark Time CPU Iterations
BM_lcg 4.44 ns 4.45 ns 154482759
AFTER:
Benchmark Time CPU Iterations
BM_lcg 2.09 ns 2.09 ns 344615385
Double the speed