Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update health tests to execute locally per role #356

Merged
merged 31 commits into from
Jan 25, 2025

Conversation

arudell
Copy link
Member

@arudell arudell commented Nov 27, 2024

Description

Summary of changes:
This pull request includes several updates and improvements to the SDN diagnostics scripts. The changes primarily focus on adding new diagnostic commands, updating configurations, and enhancing existing functions.

New Diagnostic Commands Added:

  • Added new commands such as Debug-SdnGateway, Debug-SdnLoadBalancerMux, Debug-SdnNetworkController, and Debug-SdnServer to the src/SdnDiagnostics.psd1 file.
  • Added additional test commands like Test-SdnClusterServiceState, Test-SdnDiagnosticsCleanupTaskEnabled, and more to the src/SdnDiagnostics.psd1 file.

Configuration Updates:

  • Updated the src/modules/SdnDiag.Health.Config.psd1 file to include new health validation tests such as Test-SdnDiagnosticsCleanupTaskEnabled, Test-SdnNetworkControllerApiNameResolution, and others. [1] [2]
  • Added new health fault configurations to the src/modules/SdnDiag.Health.Config.psd1 file.

Function Enhancements:

  • Modified the Repair-SdnDiagnosticsScheduledTask function to accept a mandatory TaskName parameter instead of using a switch statement to determine the task name. [1] [2]
  • Simplified the Confirm-IsCertSelfSigned function by removing the type constraint on the Certificate parameter.

New Classes and Functions:

  • Introduced new classes MuxConfig and MuxStatistics in the src/modules/SdnDiag.LoadBalancerMux.psm1 file to handle MUX configuration and statistics.
  • Added new functions Get-SdnMuxConfig and Get-SdnMuxStats to retrieve MUX configuration and statistics.

Change type

  • Bug fix (non-breaking change)
  • Code style update (formatting, local variables)
  • New Feature (non-breaking change that adds new functionality without impacting existing)
  • Breaking change (fix or feature that may cause functionality impact)
  • Other

Checklist:

  • My code follows the style and contribution guidelines of this project.
  • I have tested and validated my code changes.

@arudell arudell marked this pull request as ready for review January 24, 2025 16:36
@arudell arudell requested a review from a team as a code owner January 24, 2025 16:36
@arudell arudell enabled auto-merge January 24, 2025 21:04
@arudell arudell added this pull request to the merge queue Jan 25, 2025
Merged via the queue into main with commit f7b4419 Jan 25, 2025
4 of 5 checks passed
@arudell arudell deleted the move-debug-tests-to-local branch January 25, 2025 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants