Skip to content

feat: Support Choosing Fabric WSPL FQDN #2376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lhrotk
Copy link
Contributor

@lhrotk lhrotk commented May 20, 2025

N/A

What changes are proposed in this pull request?

When workspace pl is enabled, FQDNs are different

How is this patch tested?

Manual

  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.

@lhrotk lhrotk requested a review from mhamilton723 as a code owner May 20, 2025 07:42
@lhrotk
Copy link
Contributor Author

lhrotk commented May 20, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lhrotk
Copy link
Contributor Author

lhrotk commented May 21, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2025

Codecov Report

Attention: Patch coverage is 2.85714% with 34 lines in your changes missing coverage. Please review.

Project coverage is 84.44%. Comparing base (6c95bf0) to head (51862bf).

Files with missing lines Patch % Lines
...crosoft/azure/synapse/ml/fabric/FabricClient.scala 2.85% 34 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2376      +/-   ##
==========================================
- Coverage   84.69%   84.44%   -0.26%     
==========================================
  Files         331      331              
  Lines       17180    17199      +19     
  Branches     1544     1541       -3     
==========================================
- Hits        14551    14524      -27     
- Misses       2629     2675      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants