Skip to content

Fix color in mesh rendering #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gongminmin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix color in mesh rendering #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion trellis/renderers/mesh_renderer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def render(
mesh : MeshExtractResult,
extrinsics: torch.Tensor,
intrinsics: torch.Tensor,
return_types = ["mask", "normal", "depth"]
return_types = ["mask", "normal", "depth", "color"]
) -> edict:
"""
Render the mesh.
Expand Down
4 changes: 2 additions & 2 deletions trellis/utils/postprocessing_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ def tv_loss(texture):


def to_glb(
app_rep: Union[Strivec, Gaussian],
app_rep: Union[Strivec, Gaussian, MeshExtractResult],
mesh: MeshExtractResult,
simplify: float = 0.95,
fill_holes: bool = True,
Expand All @@ -410,7 +410,7 @@ def to_glb(
Convert a generated asset to a glb file.

Args:
app_rep (Union[Strivec, Gaussian]): Appearance representation.
app_rep (Union[Strivec, Gaussian, MeshExtractResult]): Appearance representation.
mesh (MeshExtractResult): Extracted mesh.
simplify (float): Ratio of faces to remove in simplification.
fill_holes (bool): Whether to fill holes in the mesh.
Expand Down
2 changes: 2 additions & 0 deletions trellis/utils/render_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,9 @@ def render_frames(sample, extrinsics, intrinsics, options={}, colors_overwrite=N
rets['depth'].append(None)
else:
res = renderer.render(sample, extr, intr)
if 'color' not in rets: rets['color'] = []
if 'normal' not in rets: rets['normal'] = []
rets['color'].append(np.clip(res['color'].detach().cpu().numpy().transpose(1, 2, 0) * 255, 0, 255).astype(np.uint8))
rets['normal'].append(np.clip(res['normal'].detach().cpu().numpy().transpose(1, 2, 0) * 255, 0, 255).astype(np.uint8))
return rets

Expand Down