Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set developer settings when using the devcontainer in python folder #157

Merged
merged 5 commits into from
Jan 4, 2024

Conversation

hillary-mutisya
Copy link
Contributor

@hillary-mutisya hillary-mutisya commented Jan 3, 2024

This change configures hatch to set up the python virtual environment in the project folder when using the dev container. We also set the python interpretter path to the hatch virtual environment.

@DanielRosenwasser
Copy link
Member

I spoke to @luabud who confirmed that this is going to end up being unreliable across machines. She suggested instead including the settings within the devcontainer.json itself:

    // Configure tool-specific properties.
    "customizations": {
        "vscode": {
            "extensions": [
                "ms-python.python",
            ],
            "settings": {
                "python.defaultInterpreterPath": "/workspaces/TypeChat/python/.hatch/typechat/bin/python3.12"
            }
        }
    }
 

What do you think?

@hillary-mutisya
Copy link
Contributor Author

That works! I updated the PR

@hillary-mutisya hillary-mutisya changed the title Allow shared developer settings in python folder Set developer settings when using the devcontainer in python folder Jan 4, 2024
@hillary-mutisya hillary-mutisya merged commit 65e3a66 into main Jan 4, 2024
6 checks passed
@hillary-mutisya hillary-mutisya deleted the users/hillarym/py-dev branch January 4, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants