Skip to content

Conversation

@yugasun
Copy link

@yugasun yugasun commented Sep 13, 2024

No description provided.

Copy link
Contributor

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The old instructions seem to date from before there were multiple supported languages, when the only language was TS and it lived in the toplevel directory.

Copilot AI review requested due to automatic review settings November 21, 2025 07:38
Copilot finished reviewing on behalf of yugasun November 21, 2025 07:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects the installation instructions in the examples documentation by updating the cd command to navigate to the typescript subdirectory. Since the TypeChat repository contains multiple language implementations (TypeScript, Python, .NET), and the package.json for TypeScript examples is located in the typescript/ directory, this change ensures users can successfully run npm install after cloning the repository.

Key Change:

  • Updated the directory navigation command from cd TypeChat to cd TypeChat/typescript to match the repository structure

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gvanrossum
Copy link
Contributor

Sorry, I can't move help you further -- you need two reviewers from the TypeChat team. @DanielRosenwasser ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants