Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make TextEncoder.prototype.encode return Uint8Array<ArrayBuffer> #1893

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion baselines/audioworklet.generated.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -934,7 +934,7 @@ interface TextEncoder extends TextEncoderCommon {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/TextEncoder/encode)
*/
encode(input?: string): Uint8Array;
encode(input?: string): Uint8Array<ArrayBuffer>;
/**
* Runs the UTF-8 encoder on source, stores the result of that operation into destination, and returns the progress made as an object wherein read is the number of converted code units of source and written is the number of bytes modified in destination.
*
Expand Down
2 changes: 1 addition & 1 deletion baselines/dom.generated.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23199,7 +23199,7 @@ interface TextEncoder extends TextEncoderCommon {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/TextEncoder/encode)
*/
encode(input?: string): Uint8Array;
encode(input?: string): Uint8Array<ArrayBuffer>;
/**
* Runs the UTF-8 encoder on source, stores the result of that operation into destination, and returns the progress made as an object wherein read is the number of converted code units of source and written is the number of bytes modified in destination.
*
Expand Down
2 changes: 1 addition & 1 deletion baselines/serviceworker.generated.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5194,7 +5194,7 @@ interface TextEncoder extends TextEncoderCommon {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/TextEncoder/encode)
*/
encode(input?: string): Uint8Array;
encode(input?: string): Uint8Array<ArrayBuffer>;
/**
* Runs the UTF-8 encoder on source, stores the result of that operation into destination, and returns the progress made as an object wherein read is the number of converted code units of source and written is the number of bytes modified in destination.
*
Expand Down
2 changes: 1 addition & 1 deletion baselines/sharedworker.generated.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5001,7 +5001,7 @@ interface TextEncoder extends TextEncoderCommon {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/TextEncoder/encode)
*/
encode(input?: string): Uint8Array;
encode(input?: string): Uint8Array<ArrayBuffer>;
/**
* Runs the UTF-8 encoder on source, stores the result of that operation into destination, and returns the progress made as an object wherein read is the number of converted code units of source and written is the number of bytes modified in destination.
*
Expand Down
2 changes: 1 addition & 1 deletion baselines/ts5.5/audioworklet.generated.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -934,7 +934,7 @@ interface TextEncoder extends TextEncoderCommon {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/TextEncoder/encode)
*/
encode(input?: string): Uint8Array;
encode(input?: string): Uint8Array<ArrayBuffer>;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong for TS 5.5. The minimum should be TS 5.7. How do I deal with this?

/**
* Runs the UTF-8 encoder on source, stores the result of that operation into destination, and returns the progress made as an object wherein read is the number of converted code units of source and written is the number of bytes modified in destination.
*
Expand Down
2 changes: 1 addition & 1 deletion baselines/ts5.5/dom.generated.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23177,7 +23177,7 @@ interface TextEncoder extends TextEncoderCommon {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/TextEncoder/encode)
*/
encode(input?: string): Uint8Array;
encode(input?: string): Uint8Array<ArrayBuffer>;
/**
* Runs the UTF-8 encoder on source, stores the result of that operation into destination, and returns the progress made as an object wherein read is the number of converted code units of source and written is the number of bytes modified in destination.
*
Expand Down
2 changes: 1 addition & 1 deletion baselines/ts5.5/serviceworker.generated.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5194,7 +5194,7 @@ interface TextEncoder extends TextEncoderCommon {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/TextEncoder/encode)
*/
encode(input?: string): Uint8Array;
encode(input?: string): Uint8Array<ArrayBuffer>;
/**
* Runs the UTF-8 encoder on source, stores the result of that operation into destination, and returns the progress made as an object wherein read is the number of converted code units of source and written is the number of bytes modified in destination.
*
Expand Down
2 changes: 1 addition & 1 deletion baselines/ts5.5/sharedworker.generated.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5001,7 +5001,7 @@ interface TextEncoder extends TextEncoderCommon {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/TextEncoder/encode)
*/
encode(input?: string): Uint8Array;
encode(input?: string): Uint8Array<ArrayBuffer>;
/**
* Runs the UTF-8 encoder on source, stores the result of that operation into destination, and returns the progress made as an object wherein read is the number of converted code units of source and written is the number of bytes modified in destination.
*
Expand Down
2 changes: 1 addition & 1 deletion baselines/ts5.5/webworker.generated.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5924,7 +5924,7 @@ interface TextEncoder extends TextEncoderCommon {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/TextEncoder/encode)
*/
encode(input?: string): Uint8Array;
encode(input?: string): Uint8Array<ArrayBuffer>;
/**
* Runs the UTF-8 encoder on source, stores the result of that operation into destination, and returns the progress made as an object wherein read is the number of converted code units of source and written is the number of bytes modified in destination.
*
Expand Down
2 changes: 1 addition & 1 deletion baselines/webworker.generated.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5924,7 +5924,7 @@ interface TextEncoder extends TextEncoderCommon {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/TextEncoder/encode)
*/
encode(input?: string): Uint8Array;
encode(input?: string): Uint8Array<ArrayBuffer>;
/**
* Runs the UTF-8 encoder on source, stores the result of that operation into destination, and returns the progress made as an object wherein read is the number of converted code units of source and written is the number of bytes modified in destination.
*
Expand Down
13 changes: 13 additions & 0 deletions inputfiles/overridingTypes.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -3209,6 +3209,19 @@
}
}
},
"TextEncoder": {
"methods": {
"method": {
"encode": {
"signature": {
"0": {
"overrideType": "Uint8Array<ArrayBuffer>"
}
}
}
}
}
},
"TextEncoderStream": {
"properties": {
"property": {
Expand Down
Loading