Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore StartViewTransitionOptions #1918

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Restore StartViewTransitionOptions #1918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aab4303
Restore StartViewTransitionOptions
saschanaz Feb 26, 2025
d2cdcad
rebuild
saschanaz Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion baselines/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2090,6 +2090,11 @@ interface SpeechSynthesisEventInit extends EventInit {
utterance: SpeechSynthesisUtterance;
}

interface StartViewTransitionOptions {
types?: string[] | null;
update?: ViewTransitionUpdateCallback | null;
}

interface StaticRangeInit {
endContainer: Node;
endOffset: number;
Expand Down Expand Up @@ -8076,7 +8081,7 @@ interface Document extends Node, DocumentOrShadowRoot, FontFaceSource, GlobalEve
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Document/requestStorageAccess) */
requestStorageAccess(): Promise<void>;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Document/startViewTransition) */
startViewTransition(callbackOptions?: ViewTransitionUpdateCallback): ViewTransition;
startViewTransition(callbackOptions?: ViewTransitionUpdateCallback | StartViewTransitionOptions): ViewTransition;
/**
* Writes one or more HTML expressions to a document in the specified window.
* @param content Specifies the text and HTML tags to write.
Expand Down
7 changes: 6 additions & 1 deletion baselines/ts5.5/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2090,6 +2090,11 @@ interface SpeechSynthesisEventInit extends EventInit {
utterance: SpeechSynthesisUtterance;
}

interface StartViewTransitionOptions {
types?: string[] | null;
update?: ViewTransitionUpdateCallback | null;
}

interface StaticRangeInit {
endContainer: Node;
endOffset: number;
Expand Down Expand Up @@ -8069,7 +8074,7 @@ interface Document extends Node, DocumentOrShadowRoot, FontFaceSource, GlobalEve
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Document/requestStorageAccess) */
requestStorageAccess(): Promise<void>;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Document/startViewTransition) */
startViewTransition(callbackOptions?: ViewTransitionUpdateCallback): ViewTransition;
startViewTransition(callbackOptions?: ViewTransitionUpdateCallback | StartViewTransitionOptions): ViewTransition;
/**
* Writes one or more HTML expressions to a document in the specified window.
* @param content Specifies the text and HTML tags to write.
Expand Down
13 changes: 0 additions & 13 deletions inputfiles/overridingTypes.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,19 +817,6 @@
"overrideType": "NodeListOf<HTMLElement>"
}
}
},
"startViewTransition": {
"signature": {
"0": {
"param": [
// StartViewTransitionOptions is not implemented as of 2024-06
{
"name": "callbackOptions",
"type": "ViewTransitionUpdateCallback"
}
],
}
}
}
}
},
Expand Down
Loading