Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update overridingTypes.jsonc to add PointerEvent to contextmenu and auxclick #1931

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

titoBouzout
Copy link
Contributor

@titoBouzout titoBouzout commented Mar 11, 2025

It has been noted in SolidJS discord that the interface for contextmenu and auxclick events is PointerEvent not MouseEvent. MDN supports

The file being updated here has other 10 sibling entries also for the same event PointerEvent, so I am adding 2 more.

Now, I'm not completely sure why this is still outdated?/needs manual overriding, may be worth to look at that.

Thanks!

Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

@saschanaz
Copy link
Contributor

Probably because of GlobalEventHandlers being a mixin, there's some work needed to fully automate it for mixins. LGTM

@github-actions github-actions bot merged commit 6271e86 into microsoft:main Mar 11, 2025
4 of 5 checks passed
Copy link
Contributor

Merging because @saschanaz is a code-owner of all the changes - thanks!

@saschanaz
Copy link
Contributor

Oh wait this did not update the baseline.

@titoBouzout
Copy link
Contributor Author

Oh wait this did not update the baseline.

Sorry I didn't know, want me to update baseline? I can do it

@saschanaz
Copy link
Contributor

Fixed it in #1932, but this is how: npm run build && npm run baseline-accept

@titoBouzout
Copy link
Contributor Author

@saschanaz Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants