Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update MDN references and change types to Set<string> in generated definitions #1935

Closed
wants to merge 1 commit into from
Closed

fix: Update MDN references and change types to Set<string> in generated definitions #1935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions baselines/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9931,7 +9931,7 @@ interface GlobalEventHandlers {
* Fires immediately after the browser loads the object.
* @param ev The event.
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/load_event)
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/SVGElement/load_event)
*/
onload: ((this: GlobalEventHandlers, ev: Event) => any) | null;
/**
Expand Down Expand Up @@ -10743,8 +10743,6 @@ interface HTMLDialogElement extends HTMLElement {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLDialogElement/close)
*/
close(returnValue?: string): void;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLDialogElement/requestClose) */
requestClose(returnValue?: string): void;
/**
* Displays the dialog element.
*
Expand Down Expand Up @@ -24469,7 +24467,7 @@ interface ViewTransition {
readonly finished: Promise<void>;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/ViewTransition/ready) */
readonly ready: Promise<void>;
types: ViewTransitionTypeSet;
types: Set<string>;
Copy link
Contributor

@saschanaz saschanaz Mar 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ViewTransitionTypeSet is effectively Set<string>, why do we need a change here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is the case. What is the issue?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no issue, I just closed it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/ViewTransition/updateCallbackDone) */
readonly updateCallbackDone: Promise<void>;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/ViewTransition/skipTransition) */
Expand Down Expand Up @@ -29277,7 +29275,7 @@ declare var onkeyup: ((this: Window, ev: KeyboardEvent) => any) | null;
* Fires immediately after the browser loads the object.
* @param ev The event.
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/load_event)
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/SVGElement/load_event)
*/
declare var onload: ((this: Window, ev: Event) => any) | null;
/**
Expand Down
8 changes: 3 additions & 5 deletions baselines/ts5.5/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9921,7 +9921,7 @@ interface GlobalEventHandlers {
* Fires immediately after the browser loads the object.
* @param ev The event.
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/load_event)
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/SVGElement/load_event)
*/
onload: ((this: GlobalEventHandlers, ev: Event) => any) | null;
/**
Expand Down Expand Up @@ -10731,8 +10731,6 @@ interface HTMLDialogElement extends HTMLElement {
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLDialogElement/close)
*/
close(returnValue?: string): void;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLDialogElement/requestClose) */
requestClose(returnValue?: string): void;
/**
* Displays the dialog element.
*
Expand Down Expand Up @@ -24447,7 +24445,7 @@ interface ViewTransition {
readonly finished: Promise<void>;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/ViewTransition/ready) */
readonly ready: Promise<void>;
types: ViewTransitionTypeSet;
types: Set<string>;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/ViewTransition/updateCallbackDone) */
readonly updateCallbackDone: Promise<void>;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/ViewTransition/skipTransition) */
Expand Down Expand Up @@ -29255,7 +29253,7 @@ declare var onkeyup: ((this: Window, ev: KeyboardEvent) => any) | null;
* Fires immediately after the browser loads the object.
* @param ev The event.
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/load_event)
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/SVGElement/load_event)
*/
declare var onload: ((this: Window, ev: Event) => any) | null;
/**
Expand Down
10 changes: 10 additions & 0 deletions inputfiles/overridingTypes.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3633,6 +3633,16 @@
}
}
}
},
"ViewTransition": {
"properties": {
"property": {
"types": {
"name": "types",
"overrideType": "Set<string>"
}
}
}
}
}
},
Expand Down
Loading